STM32: Replace HAL register operations #97329
Conversation
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
MaureenHelm,
avisconti,
djiatsaf-st,
erwango,
etienne-lms,
jeppenodgaard,
marwaiehm-st,
mathieuchopstm,
nordic-krch,
teburd,
tristan-google,
ubieda and
yperess
|
Waiting for test results to unblock. |
gautierg-st
force-pushed
the
remove_hal_reg_op
branch
from
7b6ab32 to
c3ab6e2
Compare
zephyrbot
requested review from
alexanderwachter,
andyross,
bjarki-andreasen,
ceolin,
danieldegrasse and
dcpleung
gautierg-st
force-pushed
the
remove_hal_reg_op
branch
from
3658a6a to
f97903d
Compare
gautierg-st
force-pushed
the
remove_hal_reg_op
branch
2 times, most recently
from
a5f466b to
ea37e79
Compare
|
Rebased to fix conflicts. |
drivers/adc/adc_stm32.c
Outdated
|
|
||
| uintptr_t addr = (uintptr_t)adc + reg; | ||
| size_t reg32_offset = reg / sizeof(uint32_t); | ||
| uint32_t *addr = (uint32_t *)config->base + reg32_offset; |
There was a problem hiding this comment.
| uint32_t *addr = (uint32_t *)config->base + reg32_offset; | |
| volatile uint32_t *addr = (volatile uint32_t *)config->base + reg32_offset; |
This should have raised a compiler warning (I didn't check if it did or not)
There was a problem hiding this comment.
+ outside PR scope but now that the STM32 helper functions exist, maybe we don't need these {get,set}_reg_value() helpers?
There was a problem hiding this comment.
This should have raised a compiler warning (I didn't check if it did or not)
The many places where stm32_reg_xxx() are used use a pointer argument that is not an explicit volatile data pointer. I don't think it's needed here. Actaully, I don't think the address argument of these helper functions need to be volatile. The cast is done in the sys_xxx() functions and that should be enough.
There was a problem hiding this comment.
This should have raised a compiler warning (I didn't check if it did or not)
The many places where
stm32_reg_xxx()are used use a pointer argument that is not an explicitvolatiledata pointer. I don't think it's needed here. Actaully, I don't think theaddressargument of these helper functions need to bevolatile. The cast is done in the sys_xxx() functions and that should be enough.
You're right, it is probably allowed to up-cast a uint32_t * to volatile uint32_t * because the former is less strict than the latter (same as const uint32_t -> const uint32_t *). Still better to cast to proper type explicitly IMO.
Add a set of bitops functions in order to replace the STM32 HAL bitops macros throughout the drivers. Signed-off-by: Guillaume Gautier <[email protected]>
For all STM32 drivers, replace the SET_BIT macro (defined in the STM32 HAL) by stm32_reg_set_bits defined in Zephyr. Signed-off-by: Guillaume Gautier <[email protected]>
For all STM32 drivers, replace the CLEAR_BIT macro (defined in the STM32 HAL) by stm32_reg_clear_bits defined in Zephyr. Signed-off-by: Guillaume Gautier <[email protected]>
For all STM32 drivers and SoC, replace the READ_BIT macro (defined in the STM32 HAL) by stm32_reg_read_bits. Fixes some cases where the return value was tested like a boolean despite not being one. Signed-off-by: Guillaume Gautier <[email protected]>
For all STM32 drivers and SoC, replace the WRITE_REG macro and the LL_xxx_WriteReg functions (defined in the STM32 HAL) by stm32_reg_write defined in Zephyr. Signed-off-by: Guillaume Gautier <[email protected]>
For all STM32 drivers and SoC, replace the READ_REG macro and the LL_xxx_ReadReg functions (defined in the STM32 HAL) by stm32_reg_read defined in Zephyr. Signed-off-by: Guillaume Gautier <[email protected]>
For all STM32 drivers and SoC, replace the MODIFY_REG macro (defined in the STM32 HAL) by stm32_reg_modify_bits defined in Zephyr. Signed-off-by: Guillaume Gautier <[email protected]>
Call stm32_reg_set_bits instead of stm32_reg_read then stm32_reg_write. Signed-off-by: Guillaume Gautier <[email protected]>
Use dedicated set/clear bits function instead of reading/masking/writing manually. Signed-off-by: Guillaume Gautier <[email protected]>
gautierg-st
force-pushed
the
remove_hal_reg_op
branch
from
ea37e79 to
b18ff3c
Compare
|
9 participants
This PR replaces the STM32 HAL register operations macros (such as WRITE_REG or MODIFY_REG) and functions (such as LL_I2C_WriteReg) by Zephyr equivalents in all STM32 drivers and SoC.